Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-11090] use path alias for log message imports #987

Merged
merged 1 commit into from
Jan 23, 2025
Merged

[FSSDK-11090] use path alias for log message imports #987

merged 1 commit into from
Jan 23, 2025

Conversation

raju-opti
Copy link
Contributor

Summary

add aliases for log message modules, which allows using a different generated file during build, facilitating tree shaking of log messages.

Test plan

  • all existing tests should pass

Issues

  • FSSDK-11090

@raju-opti raju-opti requested a review from a team as a code owner January 22, 2025 13:39
@coveralls
Copy link

Coverage Status

coverage: 81.915% (-0.006%) from 81.921%
when pulling 884202b on raju/log-alias
into 3d2523d on master.

junaed-optimizely
junaed-optimizely approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@junaed-optimizely junaed-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raju-opti raju-opti merged commit 9adc544 into master Jan 23, 2025
11 of 19 checks passed
@raju-opti raju-opti deleted the raju/log-alias branch January 23, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junaed-optimizely junaed-optimizely junaed-optimizely approved these changes

Assignees

@raju-opti raju-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raju-opti @coveralls @junaed-optimizely