Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-10766] UPS batch processing #953

Merged
merged 9 commits into from
Nov 4, 2024

Conversation

junaed-optimizely
Copy link
Contributor

@junaed-optimizely junaed-optimizely commented Oct 29, 2024

Summary

Currently, decideForKeys loops over the list of flags and calls decide for each, which in turn calls ups. This PR batches UPS calls when using decideForKeys.

Test plan

  • Existing tests have been updated with the new changes
  • New test cases added

Issues

@junaed-optimizely junaed-optimizely changed the title [FSSDK-10766] decide & decideForKeys adjustment [FSSDK-10766] UPS batch processing Oct 29, 2024
@coveralls
Copy link

coveralls commented Oct 29, 2024

Coverage Status

coverage: 90.577% (+0.02%) from 90.558%
when pulling db69636 on junaed/fssdk-10766-batch-ups
into 5a413d3 on 5.x.x.

@junaed-optimizely junaed-optimizely marked this pull request as ready for review November 1, 2024 08:03
@junaed-optimizely junaed-optimizely requested a review from a team as a code owner November 1, 2024 08:03
Copy link
Contributor

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/optimizely/index.ts Show resolved Hide resolved
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/core/decision_service/index.tests.js Show resolved Hide resolved
lib/core/decision_service/index.tests.js Outdated Show resolved Hide resolved
lib/optimizely/index.tests.js Show resolved Hide resolved
@junaed-optimizely junaed-optimizely merged commit d20228b into 5.x.x Nov 4, 2024
19 checks passed
@junaed-optimizely junaed-optimizely deleted the junaed/fssdk-10766-batch-ups branch November 4, 2024 16:00
junaed-optimizely added a commit that referenced this pull request Nov 26, 2024
decide & decideForKeys adjustment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants