Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-11082] fix: big integer conversion issue #556

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[FSSDK-11082] fix: big integer conversion issue #556

wants to merge 2 commits into from

Conversation

muzahidul-opti
Copy link
Contributor

@muzahidul-opti muzahidul-opti commented Jan 17, 2025 •
edited
Loading

Summary

Test plan

  • All previous test cases should be passed

Issues

@muzahidul-opti muzahidul-opti marked this pull request as ready for review January 17, 2025 14:28
@muzahidul-opti muzahidul-opti requested a review from a team as a code owner January 17, 2025 14:28
@muzahidul-opti muzahidul-opti requested a review from jaeopt January 17, 2025 17:12
jaeopt
jaeopt approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - interesting we didn't get any request for long integer support in java-sdk before :)

@iago-zwift
Copy link

I wonder why also, but this should fix the issue we're having. Any news on when the version with this fix will be released?

@muzahidul-opti
Copy link
Contributor Author

I wonder why also, but this should fix the issue we're having. Any news on when the version with this fix will be released?

We are running out of time this sprint. Hopefully, we can release it in the next sprint.

@iago-zwift
Copy link

Thank you @muzahidul-opti!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@muzahidul-opti muzahidul-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muzahidul-opti @iago-zwift @jaeopt