Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support Wicket 7.10.0 #24

Open
wants to merge 2 commits into
base: v4.x.y
Choose a base branch
from

Conversation

mattrpav
Copy link
Member

No description provided.

mattrpav added 2 commits March 28, 2018 14:35
…ts to pass during release as well)

TODO: Upgrade itests to use newer pax-exam that allows for running current project version as the version number
@mattrpav
Copy link
Member Author

Strange.. the failure in the integration test is solved by the updating of the project version in the pax-exam setup and works-for-me locally. I imagine travis-ci cleans out the local repo between builds. Thoughts?

@laeubi
Copy link
Member

laeubi commented Mar 30, 2018

Have you tried cleaning your local maven repro?
From the POM the Pax-Wicket version should be 4.0.1-SNAPSHOT your test references 4.0.0 as far as I can see...

@mattrpav
Copy link
Member Author

@laeubi the tests all pass locally. The pax-exam test previously had version 3.0.5-SNAPSHOT specified for the pax-wicket version to be tested. I specified 4.0.0 for it to stabilize temporarily, and not need to be changed every build.

see: IssueTest.java#L80

The full fix is to update pax-exam and leverage the feature that allows it to use the current project version as the feature version.

That being said, Travis CI build still isn't getting the same results as my local build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants