Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support installation on Windows #42

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

Br1ght0ne
Copy link
Contributor

Close #13.

After testing feature/windows branch locally for some time, I can safely say that it's ready. So I rebased it onto latest master and added a CI job for Windows releases. Hope it helps!

@oppiliappan oppiliappan merged commit 91cb3eb into oppiliappan:master Jul 23, 2020
@oppiliappan
Copy link
Owner

Thanks for your work on this! I have added some bits to conditionally compile with termion on linux and crossterm on windows, (crossterm causes the screen to flash on refresh).

@oppiliappan
Copy link
Owner

Ah, that wouldn't quite work, rust tries to build cursive with the termion feature on all platforms, even though it doesn't need it on windows. Currently, cfg(target_os = "...") in Cargo.toml is a nightly only feature.

@oppiliappan
Copy link
Owner

I have updated dijo to now support compile time feature flags, unix for termion and windows for crossterm, but I receive this on completion of CI builds on windows:

    Finished release [optimized] target(s) in 5m 01s
C:\ProgramData\Chocolatey\lib\mingw\tools\install\mingw64\x86_64-w64-mingw32\bin\strip.exe: 'target/release/dijo': No such file
##[error]Process completed with exit code 1.

should this perhaps be target\release\dijo?

@oppiliappan
Copy link
Owner

should this perhaps be target\release\dijo?

It was target/release/dijo.exe.

I have sort of worked this out by switching to the pancurses backend, the build is working fine with your CI additions!

@Br1ght0ne
Copy link
Contributor Author

Thanks for figuring it out @NerdyPepper!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install on windows
2 participants