Fix appcompat custom view fragment tag usage lint error

[tobioyelekan]

Explanation

Fixes #5168

1. For AppCompatCustomView, replaced it with AppCompat Views
2. For FragmentTagUsage, replaced <fragment/> with <androidx.fragment.app.FragmentContainerView/>. Made some changes to NavigationDrawerFragment to:

• ensured setUpDrawer() is called first to initialize the drawerLayout, toolbar and menuItemId
• followed by onCreateView() ensuring to bind the fragment
• followed on onViewCreated() to setup drawer functions/listeners

3. Faced an issue similar to drawer not working, by minimising and resuming the app, (the drawer button stopped working).

• Fixed this by removing onRestart() from respective Activies making a call to setUpNavigationDrawer() which at that point is not necessary, since the fragment has been inflated initially, and would be re-inflated if the fragment is recreated.

4. Also tested this bug following the steps to reproduce. No issues encountered

Lint report (Before):

Lint report (After):

Screen Record

Screen.Recording.2024-11-24.at.6.38.22.AM.mov

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

[tobioyelekan]

@adhiamboperes PTAL

[github-actions]

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 1220 bytes (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 520 bytes (Removed)

Method count: 259595 (old), 259578 (new), 17 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6816 (old), 6816 (new), 0 (No change)

• Anim: 43 (old), 43 (new), 0 (No change)
• Animator: 26 (old), 26 (new), 0 (No change)
• Array: 15 (old), 15 (new), 0 (No change)
• Attr: 922 (old), 922 (new), 0 (No change)
• Bool: 9 (old), 9 (new), 0 (No change)
• Color: 967 (old), 967 (new), 0 (No change)
• Dimen: 1048 (old), 1048 (new), 0 (No change)
• Drawable: 380 (old), 380 (new), 0 (No change)
• Id: 1275 (old), 1275 (new), 0 (No change)
• Integer: 37 (old), 37 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 380 (old), 380 (new), 0 (No change)
• Menu: 3 (old), 3 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• Raw: 2 (old), 2 (new), 0 (No change)
• String: 850 (old), 850 (new), 0 (No change)
• Style: 831 (old), 831 (new), 0 (No change)
• Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 1224 bytes (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 1353 bytes (Removed)
Method count: 259595 (old), 259578 (new), 17 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 184 bytes (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 412 bytes (Removed)

Method count: 116054 (old), 116044 (new), 10 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5784 (new), 0 (No change)

• Anim: 33 (old), 33 (new), 0 (No change)
• Animator: 24 (old), 24 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 888 (old), 888 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 820 (old), 820 (new), 0 (No change)
• Dimen: 780 (old), 780 (new), 0 (No change)
• Drawable: 342 (old), 342 (new), 0 (No change)
• Id: 1221 (old), 1221 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 343 (old), 343 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 783 (old), 783 (new), 0 (No change)
• Style: 472 (old), 472 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 184 bytes (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 3524 bytes (Removed)
Method count: 116054 (old), 116044 (new), 10 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 264 bytes (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 1068 bytes (Removed)

Method count: 116060 (old), 116050 (new), 10 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5784 (new), 0 (No change)

• Anim: 33 (old), 33 (new), 0 (No change)
• Animator: 24 (old), 24 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 888 (old), 888 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 820 (old), 820 (new), 0 (No change)
• Dimen: 780 (old), 780 (new), 0 (No change)
• Drawable: 342 (old), 342 (new), 0 (No change)
• Id: 1221 (old), 1221 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 343 (old), 343 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 783 (old), 783 (new), 0 (No change)
• Style: 472 (old), 472 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 268 bytes (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 156 bytes (Removed)
Method count: 116060 (old), 116050 (new), 10 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 340 bytes (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 295 bytes (Removed)

Method count: 116060 (old), 116050 (new), 10 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5784 (new), 0 (No change)

• Anim: 33 (old), 33 (new), 0 (No change)
• Animator: 24 (old), 24 (new), 0 (No change)
• Array: 14 (old), 14 (new), 0 (No change)
• Attr: 888 (old), 888 (new), 0 (No change)
• Bool: 8 (old), 8 (new), 0 (No change)
• Color: 820 (old), 820 (new), 0 (No change)
• Dimen: 780 (old), 780 (new), 0 (No change)
• Drawable: 342 (old), 342 (new), 0 (No change)
• Id: 1221 (old), 1221 (new), 0 (No change)
• Integer: 32 (old), 32 (new), 0 (No change)
• Interpolator: 11 (old), 11 (new), 0 (No change)
• Layout: 343 (old), 343 (new), 0 (No change)
• Menu: 1 (old), 1 (new), 0 (No change)
• Mipmap: 1 (old), 1 (new), 0 (No change)
• Plurals: 10 (old), 10 (new), 0 (No change)
• String: 783 (old), 783 (new), 0 (No change)
• Style: 472 (old), 472 (new), 0 (No change)
• Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

• hdpi (same)
• ldpi (same)
• mdpi (same)
• tvdpi (same)
• xhdpi (same)
• xxhdpi (same)
• xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 344 bytes (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 101 bytes (Added)
Method count: 116060 (old), 116050 (new), 10 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)