Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN: OpenVPN: Instances - fix "auth-gen-token" and "reneg-sec" value validation #8203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devopsoffice-ivan
Copy link

Allow saving config when reneg-sec is set to zero and auth-gen-token has no value, but prevents saving config when both parameters are set to zero.
Setting both parameters to zero results invalid configuration with error message:
Options error: --auth-gen-token needs a non-infinite --renegotiate_seconds setting

@AdSchellevis AdSchellevis self-assigned this Jan 11, 2025
@fichtner
Copy link
Member

Just for further reference this is related to #7690

@devopsoffice-ivan
Copy link
Author

Yes, #7690 fixes a bad config value combination for reneg-sec and auth-gen-token (reneg-sec == 0 and auth-gen-token > 0) but blocks setting reneg-sec == 0 and empty auth-gen-token value.
Setting both reneg-sec and auth-gen-token to zero results an invalid configuration also, so an empty auth-gen-token value should be used when reneg-sec is set to zero. In this case auth-gen-token is skipped from generated configuration, just reneg-sec is included and the result is a valid generated configuration.
This patch allows setting empty value for auth-gen-token when reneg-sec is set to zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants