firewall/nat: Add type to add-unassociated so that the generated firewall rule can be edited #8198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wall rule can be edited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Firewall: NAT: Port Forward, there is the option to add:
The associated filter rule links a firewall rule, and prevents it from being editable by not giving it a type. If the NAT rule is updated, the linked firewall rule is updated too.
The unassociated filter rule does not link a firewall rule, but also does not set a type. The firewall rule is not updated when the NAT rule is updated. That made it useless.
I think it's a bug, so I added a type to the unassociated filter rule. This makes it editable in the GUI after creation.