2515 Adding import and export #2571
Conversation
ziti/cmd/ascode/download/download.go
Outdated
| } | ||
| cas, err := d.GetCertificateAuthorities() | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
does this mean it stops at the first error? that could be .... annoying if it takes a while for this to run?
There was a problem hiding this comment.
yes, it stops at errors but the command can be rerun as many times as needed because it checks if the entity exists and skip it
|
|
||
| // convert to a map of values | ||
| m := d.ToMap(item) | ||
| d.Filter(m, []string{"id", "_links", "createdAt", "updatedAt"}) |
There was a problem hiding this comment.
d.Filter(m, []string{"id", "_links", "createdAt", "updatedAt"}) seems like a good candidate to refactor imo
|
|
||
| // filter unwanted properties | ||
| d.Filter(m, []string{"id", "_links", "createdAt", "updatedAt", | ||
| "edgeRouterRolesDisplay", "identityRolesDisplay", "isSystem"}) |
There was a problem hiding this comment.
"isSystem" is really something we would want to filter? should any "system" entities be exported/imported at all?
There was a problem hiding this comment.
My thought was that anything marked as isSystem shouldn't be included and it's filtered out because it's not a "valuable" property in that it's not settable.
| m := d.ToMap(item) | ||
|
|
||
| // filter unwanted properties | ||
| d.Filter(m, []string{"id", "_links", "createdAt", "updatedAt"}) |
There was a problem hiding this comment.
CAs should probably come along with a warning, indicating the user is going to need to re-verify the CA on import. it might be there, but if not, that should be added to avoid the confusion when they import and the ca is not "verified"
Support in the cli to import entities into a network and exporting entities from a network. Supports both json and yaml.
closes #2515