refinements to ops verify-traffic to integrate and work with ziti edge login #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dovholuknf
force-pushed
the
ops-verify-login
branch
from
58ae0fc to
8458b54
Compare
plorenz
reviewed
Oct 31, 2024
| @@ -91,7 +91,7 @@ type HybridStorage struct { | |||
| serviceUsers cmap.ConcurrentMap[string, *Client] | |||
|
|
|||
| startOnce sync.Once | |||
There was a problem hiding this comment.
If this is unused, should we just remove it?
There was a problem hiding this comment.
dunno. it's an @andrewpmartinez question. I just made the linter happy :) i was pointed it out to andrew...
plorenz
reviewed
Oct 31, 2024
| @@ -48,7 +49,7 @@ type stringMapList []interface{} | |||
|
|
|||
| type StringMap map[string]interface{} | |||
|
|
|||
There was a problem hiding this comment.
Why add this, just to ignore it?
There was a problem hiding this comment.
meh - it was just a consistency thing... all the other commands pass these params so it was consistent. i had it with no params, but then verify-traffic needed in/out streams... so -- yeah that's 'why'
plorenz
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the existing ziti ops verify-traffic were not integrated with the ziti edge login functionality. Jens needs/wants an example of how to integrate better with ziti login but apparently we haven't done that yet when using the edge-apis library.
This should provide a mechanism to obtain a new management client from the edge-apis library while integrating with ziti edge login as well. This will allow not only for updb style login but also enables cert/key/file-based login:
Using an identity file greatly simplifies the command and is more secure than shipping a user/pwd. example:
