-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdk hosting test #1449
sdk hosting test #1449
Conversation
plorenz
commented
Oct 18, 2023
- Add fablab test for SDK hosting
- update for fablab changes
8e062e8
to
1a7cf83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OpenAPI Specs all need to be updated w/ the new HTTP Status code that can return. Depending on the client, if an invalid code is returned, it might panic or return a useless "unexpected HTTP status code" error with no way to see the actual response. At best, you get the raw response and hit a generic handler in the end client's code.
This is also not backward compatible w/ older generated clients. So, a version change is also suggested. This also will affect the GoSDK.
There's a PR up for updating the edge-api project and the fabric API has been updated here. Should we bump the version to 0.31.0? |
7a72860
to
2271052
Compare
ad1b3d8
to
9bed8a1
Compare
I would say yes. |
Version has been bump to 0.31 |