Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk hosting test #1449

Merged
merged 2 commits into from
Oct 23, 2023
Merged

sdk hosting test #1449

merged 2 commits into from
Oct 23, 2023

Conversation

plorenz
Copy link
Member

@plorenz plorenz commented Oct 18, 2023

  • Add fablab test for SDK hosting
  • update for fablab changes

@plorenz plorenz requested review from a team as code owners October 18, 2023 01:14
@plorenz plorenz force-pushed the sdk-hosting-test branch 2 times, most recently from 8e062e8 to 1a7cf83 Compare October 18, 2023 17:43
Copy link
Member

@andrewpmartinez andrewpmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OpenAPI Specs all need to be updated w/ the new HTTP Status code that can return. Depending on the client, if an invalid code is returned, it might panic or return a useless "unexpected HTTP status code" error with no way to see the actual response. At best, you get the raw response and hit a generic handler in the end client's code.

This is also not backward compatible w/ older generated clients. So, a version change is also suggested. This also will affect the GoSDK.

@plorenz
Copy link
Member Author

plorenz commented Oct 20, 2023

The OpenAPI Specs all need to be updated w/ the new HTTP Status code that can return. Depending on the client, if an invalid code is returned, it might panic or return a useless "unexpected HTTP status code" error with no way to see the actual response. At best, you get the raw response and hit a generic handler in the end client's code.

This is also not backward compatible w/ older generated clients. So, a version change is also suggested. This also will affect the GoSDK.

There's a PR up for updating the edge-api project and the fabric API has been updated here. Should we bump the version to 0.31.0?

@andrewpmartinez
Copy link
Member

The OpenAPI Specs all need to be updated w/ the new HTTP Status code that can return. Depending on the client, if an invalid code is returned, it might panic or return a useless "unexpected HTTP status code" error with no way to see the actual response. At best, you get the raw response and hit a generic handler in the end client's code.
This is also not backward compatible w/ older generated clients. So, a version change is also suggested. This also will affect the GoSDK.

There's a PR up for updating the edge-api project and the fabric API has been updated here. Should we bump the version to 0.31.0?

I would say yes.

@plorenz
Copy link
Member Author

plorenz commented Oct 23, 2023

The OpenAPI Specs all need to be updated w/ the new HTTP Status code that can return. Depending on the client, if an invalid code is returned, it might panic or return a useless "unexpected HTTP status code" error with no way to see the actual response. At best, you get the raw response and hit a generic handler in the end client's code.
This is also not backward compatible w/ older generated clients. So, a version change is also suggested. This also will affect the GoSDK.

There's a PR up for updating the edge-api project and the fabric API has been updated here. Should we bump the version to 0.31.0?

I would say yes.

Version has been bump to 0.31

@plorenz plorenz merged commit 76365e4 into release-next Oct 23, 2023
17 checks passed
@plorenz plorenz deleted the sdk-hosting-test branch October 23, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants