Do fewer session refreshes. Fixes #468 #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scareything
approved these changes
Dec 14, 2023
ziti/ziti.go
Outdated
| svcRefreshInterval = DefaultServiceRefreshInterval | ||
| } | ||
| if svcRefreshInterval < time.Second { | ||
| svcRefreshInterval = time.Second |
There was a problem hiding this comment.
Maybe this is too aggressive for a default (when the caller probably made a mistake)? Also a minRefreshInterval constant to cover session and service refreshes might make sense.
There was a problem hiding this comment.
I was thinking that a developer might want to set it this low. So if the dev forgot to set it at all, it will get set to the default value, but if they have set it to something low, we'll cap it at 1 second.
I'll add a constant for minRefreshInterval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.