Create a cleaner temporary request object #129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Rails.application.routes.router.recognize
is not safe as it updates the passed argument, which is request in our case. Specifically it updatesrails_req.script_name
from""
to"/"
which makesrequest.path
to have double slash in the beginning. To solve this issue it has been created a temporary clean request object which will be disposed later.See also: https://github.com/openzipkin/zipkin-ruby/pull/122/files (PR that has the same line before).