Wrap indexData

[mgautierfr]

Fixes #92

[codecov]

Codecov Report

Base: 96.88% // Head: 92.87% // Decreases project coverage by -4.00% ⚠️

Coverage data is based on head (a649a61) compared to base (66dac18).
Patch coverage: 58.33% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   96.88%   92.87%   -4.01%     
==========================================
  Files           1        1              
  Lines         417      463      +46     
==========================================
+ Hits          404      430      +26     
- Misses         13       33      +20     

Impacted Files	Coverage Δ
libzim/libzim.pyx	92.87% <58.33%> (-4.01%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[mgautierfr]

BTW, I'm not sure of the best casing.
get_indexdata, get_indexData, get_index_data ?
get_wordcount, get_word_count, get_wordCount, get_wordscount ?

[rgaudin]

BTW, I'm not sure of the best casing. get_indexdata, get_indexData, get_index_data ? get_wordcount, get_word_count, get_wordCount, get_wordscount ?

Ah I was wondering also what would be the most self-explanatory.

I'd suggest: get_indexdata, get_wordcount, get_geoposition and so on but any of them makes sense so you should go with what you feel is more appropriate.

[mgautierfr]

I'd suggest: get_indexdata, get_wordcount, get_geoposition and so on but any of them makes sense so you should go with what you feel is more appropriate.

It is what I've used. So we are good. I let you merge if you are ok with the PR

[rgaudin]

Looks good but any exception in the IndexData methods ends up crashing the process. All the _cy_call_fct functions do enter the except block and set the trackeback in error[0] but for some reason it crashes instead of forwarding it up

tests/test_libzim_creator.py::test_exc_in_indexdata
[DEBUG] inside has_indexdata()
[DEBUG] captured exception: Some User Exception
[DEBUG] error[0]= b'Traceback (most recent call last):\n  File "libzim/libzim.pyx", line 148, in libzim.bool_cy_call_fct\n    return call_method(obj, method)\n  File "libzim/libzim.pyx", line 84, in libzim.call_method\n    return func()\n  File "/Users/reg/src/pylibzim/tests/test_libzim_creator.py", line 698, in has_indexdata\n    raise IOError("Some User Exception")\nOSError: Some User Exception\n'
libc++abi: terminating with uncaught exception of type std::runtime_error: Traceback (most recent call last):
  File "libzim/libzim.pyx", line 148, in libzim.bool_cy_call_fct
    return call_method(obj, method)
  File "libzim/libzim.pyx", line 84, in libzim.call_method
    return func()
  File "/Users/reg/src/pylibzim/tests/test_libzim_creator.py", line 698, in has_indexdata
    raise IOError("Some User Exception")
OSError: Some User Exception

Fatal Python error: Aborted

[rgaudin]

Is there a reason for not using hasattr?

[kelson42]

Code coverage has dropped significantly. A bit of automated testing might be welcome.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

[kelson42]

@mgautierfr Please finish this Pr.

[mgautierfr]

Looks good but any exception in the IndexData methods ends up crashing the process. All the _cy_call_fct functions do enter the except block and set the trackeback in error[0] but for some reason it crashes instead of forwarding it up

This is more related to #42 than wrapping IndexData. I have a working version which need changes in python-libzim and libzim itself. I will create PRs soon.

[rgaudin]

As discussed, merging this despite the error handling issue and coverage.