Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary disable VisualEditor capability check #1941

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

VadimKovalenkoSNF
Copy link
Collaborator

This is a temporary PR that disables VisualEditor regression described in https://phabricator.wikimedia.org/T350117#9296451
It should be merged into the main, and then #1939 should be rebased on top of it because #1939 fixes other regressions.
Once upstream changes in MW core around VisualEditor are fixed, changes from this PR should be reverted, check #1940

@VadimKovalenkoSNF VadimKovalenkoSNF self-assigned this Nov 5, 2023
@VadimKovalenkoSNF VadimKovalenkoSNF marked this pull request as ready for review November 5, 2023 16:11
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e9812d3) 76.44% compared to head (4fed30a) 75.83%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1941      +/-   ##
==========================================
- Coverage   76.44%   75.83%   -0.62%     
==========================================
  Files          37       37              
  Lines        2985     2984       -1     
  Branches      653      653              
==========================================
- Hits         2282     2263      -19     
- Misses        609      622      +13     
- Partials       94       99       +5     
Files Coverage Δ
src/mwoffliner.lib.ts 74.72% <ø> (-0.10%) ⬇️
src/util/const.ts 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants