Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply test coverage for all endpoins #1933

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

VadimKovalenkoSNF
Copy link
Collaborator

Fixes: #1930
Blocked by: #1931

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ebd7d0) 76.14% compared to head (e9812d3) 76.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1933      +/-   ##
==========================================
+ Coverage   76.14%   76.44%   +0.30%     
==========================================
  Files          37       37              
  Lines        2985     2985              
  Branches      653      653              
==========================================
+ Hits         2273     2282       +9     
+ Misses        617      609       -8     
+ Partials       95       94       -1     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VadimKovalenkoSNF VadimKovalenkoSNF marked this pull request as ready for review October 23, 2023 08:09
Copy link
Collaborator

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelson42
Copy link
Collaborator

@VadimKovalenkoSNF I don't really understand why this should be blocked by #1931... but CI been green it looks good.

@kelson42 kelson42 merged commit 28adc40 into main Oct 26, 2023
6 checks passed
@kelson42 kelson42 deleted the 1930-apply-test-coverage-for-all-endpoins branch October 26, 2023 04:43
@VadimKovalenkoSNF
Copy link
Collaborator Author

I don't really understand why this should be blocked by #1931... but CI been green it looks good.

CI is green because I commented out parts with zimcheck like here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply test coverage for all endpoins
2 participants