Merge pull request #1945 from openzim/I1940-reintroduce-visualEditor-…

…capability-check Reintroduce VisualEditor capability check
openzim · Nov 10, 2023 · c4c2dde · c4c2dde
2 parents 87333d0 + 102c2de
commit c4c2dde
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 14 deletions.
diff --git a/src/mwoffliner.lib.ts b/src/mwoffliner.lib.ts
@@ -213,8 +213,7 @@ async function execute(argv: any) {
   await MediaWiki.hasCoordinates(downloader)
   await MediaWiki.hasWikimediaDesktopApi()
   const hasWikimediaMobileApi = await MediaWiki.hasWikimediaMobileApi()
-  // TODO: Enable back once regression Phabricator:T350117 fixed
-  // await MediaWiki.hasVisualEditorApi()
+  await MediaWiki.hasVisualEditorApi()
   await downloader.setBaseUrls(forceRender)
 
   RedisStore.setOptions(argv.redis || config.defaults.redisPath)

diff --git a/src/util/const.ts b/src/util/const.ts
@@ -20,5 +20,4 @@ export const RULE_TO_REDIRECT = /window\.top !== window\.self/
 export const WEBP_HANDLER_URL = 'https://gist.githubusercontent.com/rgaudin/60bb9cc6f187add506584258028b8ee1/raw/9d575b8e25d67eed2a9c9a91d3e053a0062d2fc7/web-handler.js'
 export const MAX_FILE_DOWNLOAD_RETRIES = 5
 export const BLACKLISTED_NS = ['Story'] // 'Story' Wikipedia namespace is content, but not indgestable by Parsoid https://github.com/openzim/mwoffliner/issues/1853
-// TODO: Enable back once regression Phabricator:T350117 fixed
-export const RENDERERS_LIST = ['WikimediaDesktop', /* 'VisualEditor',*/ 'WikimediaMobile']
+export const RENDERERS_LIST = ['WikimediaDesktop', 'VisualEditor', 'WikimediaMobile']
diff --git a/test/unit/downloader.test.ts b/test/unit/downloader.test.ts
@@ -37,8 +37,7 @@ describe('Downloader class', () => {
     await MediaWiki.hasCoordinates(downloader)
     await MediaWiki.hasWikimediaDesktopApi()
     await MediaWiki.hasWikimediaMobileApi()
-    // TODO: Enable back once regression Phabricator:T350117 fixed
-    // await MediaWiki.hasVisualEditorApi()
+    await MediaWiki.hasVisualEditorApi()
     await downloader.setBaseUrls()
   })
 

diff --git a/test/unit/mwApi.test.ts b/test/unit/mwApi.test.ts
@@ -19,8 +19,7 @@ const initMW = async (downloader: Downloader) => {
   await MediaWiki.getMwMetaData(downloader)
   await MediaWiki.hasCoordinates(downloader)
   await MediaWiki.hasWikimediaDesktopApi()
-  // TODO: Enable back once regression Phabricator:T350117 fixed
-  // await MediaWiki.hasVisualEditorApi()
+  await MediaWiki.hasVisualEditorApi()
 
   await MediaWiki.getNamespaces([], downloader)
 }

diff --git a/test/unit/renderers/renderer.builder.test.ts b/test/unit/renderers/renderer.builder.test.ts
@@ -83,8 +83,7 @@ describe('RendererBuilder', () => {
     await MediaWiki.hasCoordinates(downloader)
     await MediaWiki.hasWikimediaDesktopApi()
     await MediaWiki.hasWikimediaMobileApi()
-    // TODO: Enable back once regression Phabricator:T350117 fixed
-    // await MediaWiki.hasVisualEditorApi()
+    await MediaWiki.hasVisualEditorApi()
     await downloader.setBaseUrls()
 
     const rendererBuilderOptions = {

diff --git a/test/unit/saveArticles.test.ts b/test/unit/saveArticles.test.ts
@@ -40,8 +40,7 @@ describe('saveArticles', () => {
       await MediaWiki.hasCoordinates(downloader)
       await MediaWiki.hasWikimediaDesktopApi()
       await MediaWiki.hasWikimediaMobileApi()
-      // TODO: Enable back once regression Phabricator:T350117 fixed
-      // await MediaWiki.hasVisualEditorApi()
+      await MediaWiki.hasVisualEditorApi()
       await downloader.setBaseUrls(renderer)
       const _articlesDetail = await downloader.getArticleDetailsIds(['London'])
       const articlesDetail = mwRetToArticleDetail(_articlesDetail)

diff --git a/test/util.ts b/test/util.ts
@@ -39,8 +39,7 @@ export async function setupScrapeClasses({ mwUrl = 'https://en.wikipedia.org', f
   await MediaWiki.hasCoordinates(downloader)
   await MediaWiki.hasWikimediaDesktopApi()
   await MediaWiki.hasWikimediaMobileApi()
-  // TODO: Enable back once regression Phabricator:T350117 fixed
-  // await MediaWiki.hasVisualEditorApi()
+  await MediaWiki.hasVisualEditorApi()
 
   const dump = new Dump(format, {} as any, MediaWiki.metaData)