Retrieve and rewrite Detailed licensing pages content #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit74
force-pushed
the
detailed_licensing
branch
from
0eabee6
to
bd1b95d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## detect_special_pages #98 +/- ##
========================================================
+ Coverage 43.96% 44.45% +0.48%
========================================================
Files 17 18 +1
Lines 1053 1100 +47
Branches 149 154 +5
========================================================
+ Hits 463 489 +26
- Misses 578 599 +21
Partials 12 12 ☔ View full report in Codecov by Sentry. |
rgaudin
requested changes
Nov 27, 2024
| else: | ||
|
|
||
| def get_restriction_label(restriction_key: str): | ||
| if restriction_key == "noncommercial": |
There was a problem hiding this comment.
Use a simple map
return {"noderivatives": "No Derivatives", ...}.get(restriction_key, restriction_key)| @@ -224,6 +225,9 @@ def run(self) -> Path: | |||
| self.libretexts_index_template = self.jinja2_env.get_template( | |||
| "libretexts.index.html" | |||
| ) | |||
| self.libretexts_detailed_licensing_template = self.jinja2_env.get_template( | |||
| "libretexts.detailed-licensing.html.jinja2" | |||
There was a problem hiding this comment.
Didn't we agree on using .html extensions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #54