-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle libretexts.org glossary rewriting #66
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
==========================================
- Coverage 45.08% 44.43% -0.66%
==========================================
Files 13 14 +1
Lines 845 871 +26
Branches 111 116 +5
==========================================
+ Hits 381 387 +6
- Misses 451 471 +20
Partials 13 13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I dont see in the ticket nor in the PR why this is limited to English. Should probably be mentioned in the README and should it be a current shortcut, probably have a ticket to support other languages later
You are right, the fact this is limited to English is a shortcut I took without even really noticing it. I checked the list of ZIMs we have to build and there is some international libraries, so we should support it. I changed the way it works by:
Tested on:
|
Great ; please re-request when ready |
Ready, first commit is unchanged (just rebased), please look only at second commit for last changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 please add suggested comment
Fix #53
While a bit basic (as mentioned in the issue, we do not handle all properties and we do not handle nested glossary definitions), this is sufficient to provide the sheer added value of glossary pages.