Collapse subpages #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
=======================================
Coverage 45.08% 45.08%
=======================================
Files 13 13
Lines 845 845
Branches 111 111
=======================================
Hits 381 381
Misses 451 451
Partials 13 13 ☔ View full report in Codecov by Sentry. |
benoit74
force-pushed
the
collapse_subpages
branch
from
e34bbff
to
6ddba30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #57
Changes:
Remark: this is obviously a bit fragile since it uses online CSS classes to properly detect when we should (or shouldn't add the magic button and hide entries in excess).
It is deemed to be the best compromise so far. I tried to reuse JS / CSS from online but it is just a mess to make it work.
Screen.Recording.2024-11-11.at.11.46.10.mov