Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for images with only srcset and no src #62

Merged
merged 4 commits into from
Nov 5, 2024

Add missing tests of HTML rewriting

3a7a734
Select commit
Loading
Failed to load commit list.
Merged

Add support for images with only srcset and no src #62

Add missing tests of HTML rewriting
3a7a734
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 5, 2024 in 0s

46.49% (+8.70%) compared to 5d68d9a

View this Pull Request on Codecov

46.49% (+8.70%) compared to 5d68d9a

Details

Codecov Report

Attention: Patch coverage is 85.12397% with 18 lines in your changes missing coverage. Please review.

Project coverage is 46.49%. Comparing base (5d68d9a) to head (3a7a734).

Files with missing lines Patch % Lines
scraper/src/mindtouch2zim/html_rewriting.py 81.81% 9 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   37.79%   46.49%   +8.70%     
==========================================
  Files          10       12       +2     
  Lines         688      727      +39     
  Branches       84       94      +10     
==========================================
+ Hits          260      338      +78     
+ Misses        426      376      -50     
- Partials        2       13      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.