Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zimscraperlib session to fetch web content with automatic meaningful retries #49

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

benoit74
Copy link
Contributor

Fix #32

@benoit74 benoit74 self-assigned this Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 37.66%. Comparing base (a2b3708) to head (9c69ae6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/mindtouch2zim/processor.py 20.00% 4 Missing ⚠️
scraper/src/mindtouch2zim/client.py 50.00% 2 Missing ⚠️
scraper/src/mindtouch2zim/vimeo.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   37.57%   37.66%   +0.09%     
==========================================
  Files           9        9              
  Lines         676      677       +1     
  Branches       84       84              
==========================================
+ Hits          254      255       +1     
  Misses        420      420              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review October 28, 2024 13:23
@benoit74 benoit74 requested a review from rgaudin October 28, 2024 13:24
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from private_pages to main October 29, 2024 16:15
@benoit74 benoit74 merged commit bc02d11 into main Oct 29, 2024
10 checks passed
@benoit74 benoit74 deleted the retry_web_calls branch October 29, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add retry / back-off logic to all calls to upstream servers
2 participants