Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite HTML: <a> and <img> tags #39

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Rewrite HTML: <a> and <img> tags #39

merged 5 commits into from
Oct 25, 2024

Conversation

benoit74
Copy link
Contributor

Fix #11
Fix #12
Fix #18

Changes: see commits, I've made them mostly self explanatory if reviewed one-by-one

@benoit74 benoit74 self-assigned this Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 22.72727% with 68 lines in your changes missing coverage. Please review.

Project coverage is 42.21%. Comparing base (6540ad9) to head (8f68bf9).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/mindtouch2zim/processor.py 22.98% 67 Missing ⚠️
scraper/src/mindtouch2zim/entrypoint.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   44.28%   42.21%   -2.08%     
==========================================
  Files           8        8              
  Lines         481      552      +71     
  Branches       51       69      +18     
==========================================
+ Hits          213      233      +20     
- Misses        266      317      +51     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review October 25, 2024 08:08
@benoit74 benoit74 requested a review from rgaudin October 25, 2024 08:08
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scraper/src/mindtouch2zim/entrypoint.py Outdated Show resolved Hide resolved
@benoit74 benoit74 merged commit c2a6444 into main Oct 25, 2024
10 checks passed
@benoit74 benoit74 deleted the rewrite_links branch October 25, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop scraper if <picture> is found in content Add <img> images in ZIM Fix links in page content
2 participants