Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to content rewriting code from zimscraperlib #33

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

benoit74
Copy link
Contributor

@benoit74 benoit74 commented Oct 18, 2024

Code to rewrite CSS, JS and HTML has been moved from warc2zim to zimscraperlib by openzim/python-scraperlib#204

This PR adapts the scraper to use CSS rewriter from zimscraperlib (formerly warc2zim) and mutualize CSS handling code to avoid repetitions.

@benoit74 benoit74 self-assigned this Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 13.04348% with 20 lines in your changes missing coverage. Please review.

Project coverage is 45.69%. Comparing base (797edd3) to head (2bd3c61).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/libretexts2zim/processor.py 13.04% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   50.72%   45.69%   -5.04%     
==========================================
  Files           9        8       -1     
  Lines         554      499      -55     
  Branches       63       53      -10     
==========================================
- Hits          281      228      -53     
  Misses        269      269              
+ Partials        4        2       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from add_mathjax to main October 21, 2024 09:59
@benoit74 benoit74 marked this pull request as ready for review October 22, 2024 15:44
@benoit74 benoit74 requested a review from rgaudin October 22, 2024 15:44
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the kind of PR I like ! Where most of it is deleted file 😉

Please see the dict update suggestion before merging

scraper/src/libretexts2zim/processor.py Show resolved Hide resolved
@benoit74 benoit74 merged commit 018982a into main Oct 24, 2024
10 checks passed
@benoit74 benoit74 deleted the add_content_rewriting branch October 24, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants