Apply proper CSS for proper page display - step 2 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
- Coverage 51.48% 51.37% -0.12%
==========================================
Files 9 9
Lines 540 547 +7
Branches 61 61
==========================================
+ Hits 278 281 +3
- Misses 258 262 +4
Partials 4 4 ☔ View full report in Codecov by Sentry. |
benoit74
changed the title
benoit74
force-pushed
the
add_standard_css
branch
from
b6d1d52
to
4749161
Compare
benoit74
force-pushed
the
add_inline_css
branch
from
46a9557
to
738aa31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8
Second and final step of CSS retrieval and application: add inline CSS.
Mostly straightforward in fact, only concern was that CSS processor was not resilient to CSS parsing error, while it is quite easy to include at mostly no cost. Now done.
To be reviewed after #29