-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to c++17 #819
Move to c++17 #819
Conversation
All our compilers should handle c++17. Let's move on.
`uint32_t` is defined in `cstdint`.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #819 +/- ##
==========================================
+ Coverage 57.47% 57.53% +0.05%
==========================================
Files 98 98
Lines 4541 4540 -1
Branches 1910 1907 -3
==========================================
+ Hits 2610 2612 +2
Misses 674 674
+ Partials 1257 1254 -3
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving. Fixup commits must be squashed. Squashup commits (if any) must be fixed.
`std::iterator` is deprecated in c++17.
Or else, they will be detected as defined but not used.
Fix #757
All our compilers should handle c++17. Let's move on.
This PR also (re)add
werror=true
and fix different warnings (raised differently by different compilers)