Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default publisher set to openZIM #32

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Default publisher set to openZIM #32

merged 1 commit into from
Feb 29, 2024

Conversation

AKACHI-4
Copy link
Contributor

@AKACHI-4 AKACHI-4 commented Feb 29, 2024

Description

This pull request sets the default publisher to openZIM in the /scraper/src/fcc2zim/entrypoint.py file.

Related Issue

Fix #31

Observations

There are two files where we explicitly set the publisher to openZIM:

  • In test_scraper.py, the value is correctly set to openZIM.
    image

  • In entrypoint.py, it was originally set to OpenZIM, but has now been corrected to openZIM.
    image

@benoit74 benoit74 self-requested a review February 29, 2024 10:36
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Some remark for next PR:

  • you have to add Fix #xxx in your first comment (instead of related to issue #xxx) to link the PR with the corresponding issue (see https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
  • you must not commit your changes to a main branch but to a newly created branch (this will be especially important one we will give you developer permissions on this repo) ; the newly created branch should be name according to the intent of the changes, e.g. default_publisher

Please read https://github.com/openzim/overview/wiki/openZIM-code-contribution-workflow with a lot of attention to all details.

@benoit74 benoit74 merged commit a122107 into openzim:main Feb 29, 2024
5 checks passed
@AKACHI-4
Copy link
Contributor Author

Thanks, @benoit74. I will keep the remarks in mind for further changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harmonize default publisher to openZIM
2 participants