dnsdist: Add UCI integration, better defaults #25398
Conversation
…port Signed-off-by: Remi Gacogne <[email protected]>
Signed-off-by: Remi Gacogne <[email protected]>
Oops, good one! Done. |
net/dnsdist/Makefile
Outdated
| define Package/dnsdist/postinst/Default | ||
| #!/bin/sh | ||
| # if we are on a "real" system, IPKG_INSTROOT will be empty, | ||
| # otherwise we are in the process of building an image and | ||
| # thus on the host system | ||
| local root="$${IPKG_INSTROOT}" | ||
|
|
||
| if [ ! -e "$${root}/etc/config/dnsdist" ]; then | ||
| cp "$${root}/usr/share/dnsdist/simple.uci.conf" "$${root}/etc/config/dnsdist" | ||
| fi | ||
| endef |
There was a problem hiding this comment.
I don't think this needs to be a postinst. Conffile handling will ensure that a user's config is not overwritten. The $(INSTALL_CONF) that was removed should work just fine.
There was a problem hiding this comment.
Thanks! Given that neither Habbie nor I can remember why we introduced this change, I'm going to sleep on it and very likely revert it tomorrow :)
There was a problem hiding this comment.
I just pushed a commit reverting this change, thanks!
Signed-off-by: Remi Gacogne <[email protected]>
rgacogne
force-pushed
the
dnsdist-add-uci-integration
branch
from
373ac7c
to
c5bab74
Compare
|
I somehow managed to introduced a typo after testing my changes. Fixed now. |
oh, very subtle. both |
Maintainer: me / @Habbie
Compile tested: github actions
Run tested: x86_64 docker and TP-Link Archer C7 AC1750 v5 (pre-APK, though)
Description:
This pull request adds UCI integration for DNSdist, making it possible to configure a fair amount of features via UCI. It includes the ability to resolve DNS queries for local domains, getting the name of local devices from the DHCP leases (which is why this PR grants the
dnsdistuser access to DHCP leases), and Discovery of Designated Resolver (DDR, RFC94621) support to signal DoT and DoH support to clients on the local network.It also tunes the default settings, using values that make more sense for routers and reduce the memory usage a lot.
Signed-off-by: Remi Gacogne [email protected]