Skip to content

Commit

Permalink
coremark: fix error when it was built in the second run
Browse files Browse the repository at this point in the history
when there is an error building packages(other than coremark), and re-run with make -j1 V=s, the coremark package will report error

```
mkdir: cannot create directory '.../coremark-d5fad6bd094899101a4e5fd53af7298160ced6ab/aarch64': File exists
```

so, add a check to see if that dir is already there;

this is due to the fact that, in the second run, that folder is already created in the first run, and not removed before the second run.

also, add a '/' to the destination folder of the cp command, otherwise it will also report a "file exist" error.

the '-r' is also removed, since $(CP) already have -r

fixes immortalwrt/packages#1380

P.S. I'm not sure if this can be done by move the "mkdir" to `Build/Prepare` or `Build/Configure`, cause I'm not quite familiar with the Openwrt build system, so any comment is warmly welcome.

Signed-off-by: xlighting2017 <[email protected]>
  • Loading branch information
xlighting2017 committed Dec 17, 2024
1 parent 768b995 commit 38ecfac
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions utils/coremark/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ endif

define Build/Compile
$(SED) 's|EXE = .exe|EXE =|' $(PKG_BUILD_DIR)/posix/core_portme.mak
mkdir $(PKG_BUILD_DIR)/$(ARCH)
$(CP) -r $(PKG_BUILD_DIR)/linux/* $(PKG_BUILD_DIR)/$(ARCH)
[ -d "$(PKG_BUILD_DIR)/$(ARCH)" ] || mkdir $(PKG_BUILD_DIR)/$(ARCH)
$(CP) $(PKG_BUILD_DIR)/linux/* $(PKG_BUILD_DIR)/$(ARCH)/
$(MAKE) -C $(PKG_BUILD_DIR) PORT_DIR=$(ARCH) $(MAKE_FLAGS) \
PORT_CFLAGS="$(TARGET_CFLAGS)" XCFLAGS="$(EXTRA_CFLAGS)" compile
endef
Expand Down

0 comments on commit 38ecfac

Please sign in to comment.