phase2: signpack: fix sha256sums signatures of apk packages.adb index #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynezz
force-pushed
the
ynezz/phase2-signpack-fixes
branch
from
e6ee788
to
c1d6f19
Compare
So its more readable and diffs of changes are more clear, thus easier to review. Signed-off-by: Petr Štetiar <[email protected]>
Currently the sha256sum verification of apk's packages.adb index fails as the file is modified with `apk adbsign`, but we currently don't send the sha256sums file to the master, thus it can't be fixed during signing. So lets pack sha256sums files and ship them to master for proper signing. Fixes: a94d4e1 ("add APK signing logic") Signed-off-by: Petr Štetiar <[email protected]>
ynezz
force-pushed
the
ynezz/phase2-signpack-fixes
branch
from
c1d6f19
to
49c07ef
Compare
Fixes following warning: gitpoller.py:103: buildbot.warnings.DeprecatedApiWarning: [3.11.3 and later] pollinterval has been deprecated: please use pollInterval Signed-off-by: Petr Štetiar <[email protected]>
openwrt-bot
temporarily deployed
to
production
GitHub Actions
Inactive
openwrt-bot
temporarily deployed
to
production
GitHub Actions
Inactive
openwrt-bot
temporarily deployed
to
production
GitHub Actions
Inactive
openwrt-bot
temporarily deployed
to
production
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the sha256sum verification of apk's packages.adb index
fails as the file is modified with
apk adbsign, but we currently don'tsend the sha256sums file to the master, thus it can't be fixed during
signing.
So lets pack sha256sums files and ship them to master for proper
signing.
Fixes: a94d4e1 ("add APK signing logic")