Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Arbitrary WebAPI JS instrumentation (#642)
* Add mdn-browser-compat-data * js_instrument_modules as list * Add mdn-browser-compat * Pass a list of instrumentingFunctions * Script to generate api data * Working give or take Getting errors like OpenWPM: Error name: TypeError post_request_ajax.html:237:17 OpenWPM: Error message: can't redefine non-configurable property "UNSENT" post_request_ajax.html:238:17 * Small naming cleanup * Handle non-configurable properties * Lint * Add aspirational API * Begin migration to new JSInstrumentationRequest interface. * We build and mandate LogSettings. * We have a new JSInstrumentatinRequest that everything runs through * Preset, fingerprinting, will be specified in JSON * Continue making progress Enum for Operation * Begin implementing jsModuleRequest validation. Changing my mind - all validation and construction to be done python side. This will reduce JS overhead at runtime. * Big cleanout- js-instrumentation work moving to python. * Continue update to python js-instrumentation * Lint Can't do all the things I want to with typing due to scope when content is loaded into page. * noqa on wip jsinstrumentation file * Begin updating existing js instrument tests. * Small cleanups * Fix naming in calling instrumentJS * No display mode native for testing * Restore py test file to orig. * Support null propertiesToInstrument * Re-work instrumentObject tests * Clean-up text in test page. * Add default to getLogSettings function * Don't re-assign logSettings.propertiesToInstrument * Revert "Don't re-assign logSettings.propertiesToInstrument" This reverts commit 87ccdab. * Better assign propertiesToInstrument * Small cleanup * Make new logSettings object * Prettify * Small clean * -- BREAK -- JS Rework complete With this commit, the JS side of this PR is complete. Tests are still failing as fingerprinting implementation has not been completed on the python side, but all test_js_* tests are passing due to the core JS API rework being in place. * Write-out mdn compat data to js_instrumentation .py * Dry out js test code * Consolidate JS tests * Finish missing renames, and add test js via browser_params * pep8 * New files and failing tests. * Add a json schema for js_instrument_modules * Latest py tests * Flake8 * Ongoing progress. * More code, more tests. * flake * Rename mdn file * Add latest tests - just implement fingerprinting.json * flake8 * Add fingerprinting.json (incomplete) Mimetypes and plugins * Correct logSettings property name * Restore create_xpi as function Needed by manual_test * Make explicit option for logging to console * Process browser_params in task manager * Start being able to pass browser_params to selenium Also update manual_test to use click * Revert "Make explicit option for logging to console" This reverts commit c840fbc. * Get manual_test working with browser_params From toplevel directory run: `python -m test.manual_test --selenium --browser-params --browser-params-file=debug_params.json` * More robust test for simple fingerprinting output Can't guarantee order of string output * Add timing information when testing * Make recheck really fast. You'll never hit this recheck as it all happens before page load. * Handle all inputs properly * Debug with all window params instrumented * Load xpi we just built * Check for ff version support * Save a bunch of properties * Relax constraints on what we can instrument. Let failing happen during instrumentation by using subscript notation. Don't restrict to MDN list. * Correct stringifying * Better name example params, fix some bugs, sample a_f Some example browser_params - a_f is just working - but crushes on a page like google.com. g_l and m_z haven't been vetted yet. * flake8 * Move example browser_params file out of harms way * Add failing test for regression I introduced. * Fix for regression. * Add simple mimeTypes and plugins to fingerprinting. * Lint JS * Rm mdn_browser_comat stuff no longer needed * Remove example_browser_params They're not used in tests, were just for my testing. * Load JS_INSTRUMENT_MODULES from JSON string * Rename JS_INSTRUMENT_MODULES to JS_INSTRUMENT_SETTINGS * Fixes #28 - Instrument all window.navigator properties. * Finish removing unused mdn-compat pieces. * EventID as a shadow variable * Flake8 * Remove $ prefix and rename $instrumentionRequests -> jsInstrumentationSettings * Rename jsInstrumentationRequests->jsInstrumentationSettings * TS Lint * Remove use of "request". Rename python side as per discussion with @englehardt. Privatize most methods Numpy docstrings for public methods * Convert assertions to ValueErrors * Rename file/folder and fingerprinting -> collection_fingerprinting file JSInstrumentation.py -> js_instrumentation/__init__.py collections have their own folder * Clean-up naming in schema * Add processing of json schema to documentation * Rename js_instrumentation again and ref schema location * Pass JSON not a js string * Do copying to xpi in npm postbuild step * Fix import in manual_test * Revert "Pass JSON not a js string" This reverts commit 8eb4edb. * Add titles to schema pieces * Add docs for js_instrument_settings * Bit more README cleanup * Update README.md Co-authored-by: Steven Englehardt <[email protected]> * Move updating schema docs section * Add title * Fix typo in mac-osx hyperlink * Make the single-key dictionary clearer * Remove versions from npm package files * Clean up instrument_existing_window_property.html and js We're not using the js in two htmls now, so unify like other test files * Fix pyside instrumentation test, add more clarificaiton to README * pyside test must instrument browser apis * add more to readme to clarify instrumenting * Use example.com and example.org as localDomains * context-manage open, and flake8 Co-authored-by: Steven Englehardt <[email protected]>
- Loading branch information
1 parent
627f440
commit aefa048