Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Move QA checks as last step #289

Merged
merged 3 commits into from
Oct 30, 2023
Merged

[ci] Move QA checks as last step #289

merged 3 commits into from
Oct 30, 2023

Conversation

nemesifier
Copy link
Member

No description provided.

@nemesifier nemesifier self-assigned this Oct 30, 2023
@nemesifier nemesifier force-pushed the qa-last branch 2 times, most recently from 9b3d9ca to b2429c8 Compare October 30, 2023 17:48
@3nids
Copy link
Contributor

3nids commented Oct 30, 2023

another approach would be to have separate jobs for the QA checks than the unit tests.
Therefore everything is run in any case.

@nemesifier
Copy link
Member Author

another approach would be to have separate jobs for the QA checks than the unit tests. Therefore everything is run in any case.

Yes, we can do that, also because there's no need to run the QA checks on all the python/django combinations, we can run the QA checks just once.

Now the problem are those test failures which I do not understand where are coming from.

@3nids
Copy link
Contributor

3nids commented Oct 30, 2023

Yes, we can do that, also because there's no need to run the QA checks on all the python/django combinations, we can run the QA checks just once.

Yes!

Now the problem are those test failures which I do not understand where are coming from.

apparently, this will be fixed here #288

@nemesifier nemesifier merged commit e2438de into master Oct 30, 2023
17 of 22 checks passed
@auvipy auvipy deleted the qa-last branch October 31, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants