-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Added missing float type to InBBoxFilter schema #277
Conversation
thanks for the patch. I have started the CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your commit message does not follow our commit message style guidelines:
- missing prefix in the commit short description
Eg: "[feature/fix/change] Action performed"
Please read our guidelines at: http://openwisp.io/docs/developer/contributing.html#commit-message-style-guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @astanishevskyi! Changing the commit message to '[fix] Added missing float type to InBBoxFilter schema` will fix the QA check.
@nemesisdesign thank you, fixed |
its still failing |
I meant to amend the commit message with the text I indicated and force push it, eg:
|
81df9dc
to
bcddec6
Compare
@nemesisdesign oh, sorry. Now fixed for sure |
I had forgot about this one. |
I don't know If my merge privilege was revoked non intetionally or not. |
Fix typing in
InBBoxFilter
andDistanceToPointFilter
. The only possible values fortype
are['array', 'boolean', 'integer', 'number', 'object', 'string']
. Butfloat
can be used as format ofnumber
.Refarence to Swagger Documentation Data Types