Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support w3c revocation #2072

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

GHkrishna
Copy link
Contributor

What

This PR introduces support for W3C credential revocation. The following changes have been made:

Refactor functionality for Verify Credential and Verify Presentation.
Integrated with the Bit String Status List for checking and updating credential status.

How

Revocation Flow: Implemented the revocation flow by checking a credential status and updating the credential issuance process to handle revocable credentials.
Integration: Integrated the new revocation features with the existing system, ensuring compatibility and proper handling of revoked credentials.

Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: 535cdbd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@GHkrishna
Copy link
Contributor Author

GHkrishna commented Oct 29, 2024

Hello @TimoGlastra, wanting to create a separate PR for w3c revocation, due to some conflicts in the original PR #2024 .
The work until now, I have updated with the origin authors name.

I'll start with integrating the changes you suggested

@GHkrishna GHkrishna marked this pull request as ready for review December 3, 2024 03:19
@GHkrishna GHkrishna force-pushed the feat/support-w3c-revocation branch from b2e1d60 to 078c43c Compare December 3, 2024 03:23
@GHkrishna GHkrishna marked this pull request as draft December 4, 2024 05:16
@GHkrishna GHkrishna marked this pull request as ready for review December 22, 2024 09:24
@GHkrishna GHkrishna marked this pull request as draft December 23, 2024 04:36
agentContext: AgentContext,
options: RevokeCredentialOptions
) {
const credentialRecod = await this.getCredentialRecordById(agentContext, options.credentialRecordId)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think we should not use the credentialRecord to get tags as credentialRecord may or may not be present in wallet. To get the claimFormat we can use options

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh yes you are right. Also as the specs suggest the issuer may not always be the one revoking the credential. Will change it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants