feat: added support for human readable predicates #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #994 +/- ##
==========================================
+ Coverage 60.52% 60.73% +0.20%
==========================================
Files 178 178
Lines 5323 5379 +56
Branches 1511 1528 +17
==========================================
+ Hits 3222 3267 +45
- Misses 2076 2087 +11
Partials 25 25
|
Signed-off-by: wadeking98 <[email protected]>
wadeking98
force-pushed
the
feat-human-readable-predicates
branch
from
7af4497 to
fd0f180
Compare
| @@ -137,6 +146,9 @@ const CredentialCard11: React.FC<CredentialCard11Props> = ({ | |||
| resizeMode: 'contain', | |||
| borderRadius: 10, | |||
| }, | |||
| attributeValueContainer: { | |||
| width: '90%', | |||
There was a problem hiding this comment.
Just curious, what issue does this percentage width fix?
There was a problem hiding this comment.
it stops the text from overflowing the credential card, I tried a couple other approaches like flex wrap and whatnot but this is the best I could find
There was a problem hiding this comment.
I think the reason I had to resort to this approach is because the credential card has overflow: hidden set for the watermark, so things like text will overflow and get cut off rather than wrapping
| @@ -59,6 +60,7 @@ const SharedDataCard: React.FC<{ sharedData: GroupedSharedProofDataItem }> = ({ | |||
| elevation: 5, | |||
| }, | |||
| cardAttributes: { | |||
| width: '65%', | |||
| @@ -391,6 +391,12 @@ const translation = { | |||
| "CustomOfferParagraph2": "Não reconhece a organização. Verifique sua lista de Contatos. Você só recebe notificões de Contatos que você tenha adicionado.", | |||
| }, | |||
| "ProofRequest": { | |||
| "PredicateGeDate": "is after (PB)", | |||
There was a problem hiding this comment.
"PredicateGeDate": "é posterior a",
"PredicateLeDate": "é anterior a",
"PredicateGe": "é maior ou igual a",
"PredicateGr": "é maior que",
"PredicateLe": "é menor ou igual a",
"PredicateLs": "é menor que",
Signed-off-by: wadeking98 <[email protected]>
…adeking98/aries-mobile-agent-react-native into feat-human-readable-predicates
4 tasks
…ent-react-native into feat-human-readable-predicates
Signed-off-by: wadeking98 <[email protected]>
Signed-off-by: wadeking98 <[email protected]>
jleach
force-pushed
the
feat-human-readable-predicates
branch
from
824f099 to
72c1a70
Compare
Signed-off-by: wadeking98 <[email protected]>
…adeking98/aries-mobile-agent-react-native into feat-human-readable-predicates Signed-off-by: wadeking98 <[email protected]>
bryce-mcmath
previously approved these changes
Oct 19, 2023
Signed-off-by: wadeking98 <[email protected]>
bryce-mcmath
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
<=->less than or equal to,>->greater than, etc20020523->May 23, 2002Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.