-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: edit button spacing #993
Merged
wadeking98
merged 8 commits into
openwallet-foundation:main
from
wadeking98:fix-edit-button-spacing
Oct 19, 2023
Merged
fix: edit button spacing #993
wadeking98
merged 8 commits into
openwallet-foundation:main
from
wadeking98:fix-edit-button-spacing
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wadeking98 <[email protected]>
Signed-off-by: wadeking98 <[email protected]>
jleach
previously approved these changes
Oct 7, 2023
@wadeking98 I think you don't have husky setup quite right. Normally it will run the unit tests when you do a git push to make sure they all pass including snapshots are up-to-date. |
…ent-react-native into fix-edit-button-spacing
Signed-off-by: wadeking98 <[email protected]>
…98/aries-mobile-agent-react-native into fix-edit-button-spacing
Codecov Report
@@ Coverage Diff @@
## main #993 +/- ##
=======================================
Coverage 59.82% 59.82%
=======================================
Files 177 177
Lines 5168 5168
Branches 1469 1469
=======================================
Hits 3092 3092
Misses 2051 2051
Partials 25 25
|
bryce-mcmath
previously approved these changes
Oct 13, 2023
…ent-react-native into fix-edit-button-spacing Signed-off-by: wadeking98 <[email protected]>
Signed-off-by: wadeking98 <[email protected]>
jleach
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
with large wallet names the edit button would get pushed off the screen, added padding to make text wrap before it pushes button
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.