Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edit button spacing #993

Merged

Conversation

wadeking98
Copy link
Contributor

@wadeking98 wadeking98 commented Oct 6, 2023

Summary of Changes

with large wallet names the edit button would get pushed off the screen, added padding to make text wrap before it pushes button

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@wadeking98 wadeking98 requested a review from a team as a code owner October 6, 2023 23:57
jleach
jleach previously approved these changes Oct 7, 2023
@jleach jleach changed the title Fix edit button spacing fix: edit button spacing Oct 7, 2023
@jleach
Copy link
Contributor

jleach commented Oct 7, 2023

@wadeking98 I think you don't have husky setup quite right. Normally it will run the unit tests when you do a git push to make sure they all pass including snapshots are up-to-date.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #993 (aec2fbc) into main (04479f2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #993   +/-   ##
=======================================
  Coverage   59.82%   59.82%           
=======================================
  Files         177      177           
  Lines        5168     5168           
  Branches     1469     1469           
=======================================
  Hits         3092     3092           
  Misses       2051     2051           
  Partials       25       25           
Files Coverage Δ
...ages/legacy/core/App/components/misc/NewQRView.tsx 66.66% <ø> (ø)

@wadeking98 wadeking98 requested a review from jleach October 12, 2023 18:16
bryce-mcmath
bryce-mcmath previously approved these changes Oct 13, 2023
Signed-off-by: wadeking98 <[email protected]>
@jleach jleach requested a review from bryce-mcmath October 19, 2023 18:23
@wadeking98 wadeking98 merged commit 06b3e69 into openwallet-foundation:main Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants