Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: lock ruby environment #991

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

cvarjao
Copy link
Contributor

@cvarjao cvarjao commented Oct 6, 2023

Summary of Changes

Replace this text with a high-level summary of the changes included in this PR.

Related Issues

Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #991 (254ad41) into main (7c0eb18) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 254ad41 differs from pull request most recent head d29b05c. Consider uploading reports for the commit d29b05c to get more accurate results

@@            Coverage Diff             @@
##             main     #991      +/-   ##
==========================================
+ Coverage   59.20%   59.26%   +0.05%     
==========================================
  Files         176      176              
  Lines        5091     5086       -5     
  Branches     1454     1452       -2     
==========================================
  Hits         3014     3014              
+ Misses       2051     2046       -5     
  Partials       26       26              

see 1 file with indirect coverage changes

@cvarjao cvarjao marked this pull request as ready for review October 6, 2023 16:05
@cvarjao cvarjao requested a review from a team as a code owner October 6, 2023 16:05
Signed-off-by: Clécio Varjão <[email protected]>
Signed-off-by: Clécio Varjão <[email protected]>
Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bryce-mcmath bryce-mcmath merged commit 840a64b into openwallet-foundation:main Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants