Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add testIDs to wallet edit touchable components #989

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

jleach
Copy link
Contributor

@jleach jleach commented Oct 5, 2023

Summary of Changes

Add testIDs to wallet edit touchable components.

Related Issues

n/a

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@jleach jleach changed the title fix: adding test IDs fix: add testIDs to wallet edit touchable components Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #989 (6f012a2) into main (13c376f) will increase coverage by 0.02%.
The diff coverage is 83.33%.

❗ Current head 6f012a2 differs from pull request most recent head e1fc692. Consider uploading reports for the commit e1fc692 to get more accurate results

@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
+ Coverage   59.17%   59.20%   +0.02%     
==========================================
  Files         176      176              
  Lines        5095     5101       +6     
  Branches     1456     1458       +2     
==========================================
+ Hits         3015     3020       +5     
- Misses       2054     2055       +1     
  Partials       26       26              
Files Coverage Δ
...ages/legacy/core/App/components/misc/NewQRView.tsx 66.66% <ø> (ø)
packages/legacy/core/App/screens/Settings.tsx 70.83% <100.00%> (+0.41%) ⬆️
packages/legacy/core/App/utils/testable.ts 85.71% <80.00%> (-14.29%) ⬇️

Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
@jleach jleach marked this pull request as ready for review October 13, 2023 18:41
@jleach jleach requested a review from a team as a code owner October 13, 2023 18:41
@jleach jleach self-assigned this Oct 13, 2023
@jleach jleach merged commit 124a13c into openwallet-foundation:main Oct 13, 2023
5 checks passed
@jleach jleach deleted the fix/test-id branch October 13, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants