Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to rename contacts #980

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

bryce-mcmath
Copy link
Contributor

@bryce-mcmath bryce-mcmath commented Sep 26, 2023

Summary of Changes

Enables users to rename their contacts (locally). I opted to use TouchableOpacity for now because Pressable was missing too much in the way of indication that it was pressed. I think after the RN upgrade we can go through and change all of our TouchableOpacity components to Pressables at the same time and add something uniform to indicate pressed state. But in the mean time the buttons in the Contact Details screen really needed some indication that they were indeed buttons.

Here's what it looks like:
contact_rename

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #980 (9fd5d89) into main (05fbe8b) will increase coverage by 0.70%.
The diff coverage is 76.62%.

@@            Coverage Diff             @@
##             main     #980      +/-   ##
==========================================
+ Coverage   59.26%   59.96%   +0.70%     
==========================================
  Files         176      177       +1     
  Lines        5086     5145      +59     
  Branches     1452     1460       +8     
==========================================
+ Hits         3014     3085      +71     
+ Misses       2046     2035      -11     
+ Partials       26       25       -1     
Files Coverage Δ
.../core/App/components/listItems/ContactListItem.tsx 58.97% <100.00%> (+3.41%) ⬆️
.../App/components/listItems/NotificationListItem.tsx 59.37% <100.00%> (+0.98%) ⬆️
...ackages/legacy/core/App/contexts/reducers/store.ts 46.73% <100.00%> (+2.42%) ⬆️
packages/legacy/core/App/contexts/store.tsx 87.50% <ø> (ø)
packages/legacy/core/App/localization/en/index.ts 100.00% <ø> (ø)
packages/legacy/core/App/localization/fr/index.ts 100.00% <ø> (ø)
...ckages/legacy/core/App/localization/pt-br/index.ts 100.00% <ø> (ø)
...ckages/legacy/core/App/navigators/ContactStack.tsx 12.50% <ø> (ø)
packages/legacy/core/App/screens/Chat.tsx 43.38% <100.00%> (+1.27%) ⬆️
...ackages/legacy/core/App/screens/ContactDetails.tsx 63.04% <100.00%> (+60.60%) ⬆️
... and 5 more

@bryce-mcmath bryce-mcmath marked this pull request as ready for review September 26, 2023 23:23
@bryce-mcmath bryce-mcmath requested a review from a team as a code owner September 26, 2023 23:23
@bryce-mcmath bryce-mcmath added the do not merge Don't merge when label present label Sep 27, 2023
@jleach jleach force-pushed the feat/rename-contacts branch from 3b9217f to e8d2d83 Compare September 29, 2023 15:56
@jleach jleach self-requested a review September 29, 2023 18:18
@jleach jleach removed the do not merge Don't merge when label present label Oct 19, 2023
@jleach jleach force-pushed the feat/rename-contacts branch from 9fd5d89 to 79efdcd Compare October 19, 2023 16:38
@jleach jleach merged commit 04479f2 into openwallet-foundation:main Oct 19, 2023
5 checks passed
@bryce-mcmath bryce-mcmath deleted the feat/rename-contacts branch October 19, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants