-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: option to rename contacts #980
Merged
jleach
merged 3 commits into
openwallet-foundation:main
from
bryce-mcmath:feat/rename-contacts
Oct 19, 2023
Merged
feat: option to rename contacts #980
jleach
merged 3 commits into
openwallet-foundation:main
from
bryce-mcmath:feat/rename-contacts
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #980 +/- ##
==========================================
+ Coverage 59.26% 59.96% +0.70%
==========================================
Files 176 177 +1
Lines 5086 5145 +59
Branches 1452 1460 +8
==========================================
+ Hits 3014 3085 +71
+ Misses 2046 2035 -11
+ Partials 26 25 -1
|
jleach
reviewed
Sep 27, 2023
jleach
force-pushed
the
feat/rename-contacts
branch
from
September 29, 2023 15:56
3b9217f
to
e8d2d83
Compare
bryce-mcmath
force-pushed
the
feat/rename-contacts
branch
from
September 29, 2023 22:39
e8d2d83
to
90b9263
Compare
jleach
approved these changes
Sep 30, 2023
Signed-off-by: Bryce McMath <[email protected]>
Signed-off-by: Bryce McMath <[email protected]>
Signed-off-by: Bryce McMath <[email protected]>
jleach
force-pushed
the
feat/rename-contacts
branch
from
October 19, 2023 16:38
9fd5d89
to
79efdcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Enables users to rename their contacts (locally). I opted to use
TouchableOpacity
for now becausePressable
was missing too much in the way of indication that it was pressed. I think after the RN upgrade we can go through and change all of ourTouchableOpacity
components toPressable
s at the same time and add something uniform to indicate pressed state. But in the mean time the buttons in the Contact Details screen really needed some indication that they were indeed buttons.Here's what it looks like:
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.