Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: select alternative credentials for proof #978

Merged

Conversation

wadeking98
Copy link
Contributor

@wadeking98 wadeking98 commented Sep 25, 2023

Summary of Changes

Added the ability to select alternate credentials for proof request when multiple creds satisfy the proof.
altCreds

Related Issues

Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #978 (d9f27ce) into main (06b3e69) will increase coverage by 0.70%.
The diff coverage is 78.98%.

@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
+ Coverage   59.82%   60.52%   +0.70%     
==========================================
  Files         177      178       +1     
  Lines        5168     5323     +155     
  Branches     1469     1511      +42     
==========================================
+ Hits         3092     3222     +130     
- Misses       2051     2076      +25     
  Partials       25       25              
Files Coverage Δ
...legacy/core/App/components/misc/CredentialCard.tsx 88.23% <ø> (ø)
...gacy/core/App/components/misc/CredentialCard11.tsx 88.00% <100.00%> (+0.32%) ⬆️
packages/legacy/core/App/localization/en/index.ts 100.00% <ø> (ø)
packages/legacy/core/App/localization/fr/index.ts 100.00% <ø> (ø)
...ckages/legacy/core/App/localization/pt-br/index.ts 100.00% <ø> (ø)
...s/legacy/core/App/navigators/ProofRequestStack.tsx 5.00% <ø> (ø)
packages/legacy/core/App/hooks/proofs.ts 92.30% <88.88%> (-7.70%) ⬇️
.../legacy/core/App/screens/ProofChangeCredential.tsx 89.47% <89.47%> (ø)
packages/legacy/core/App/screens/ProofRequest.tsx 63.23% <72.28%> (+1.30%) ⬆️
packages/legacy/core/App/utils/helpers.ts 57.85% <77.30%> (+4.62%) ⬆️

Signed-off-by: wadeking98 <[email protected]>
@wadeking98 wadeking98 marked this pull request as ready for review September 26, 2023 00:00
@wadeking98 wadeking98 requested a review from a team as a code owner September 26, 2023 00:00
Signed-off-by: wadeking98 <[email protected]>
Signed-off-by: wadeking98 <[email protected]>
@wadeking98 wadeking98 force-pushed the feat-select-proof-cred branch 2 times, most recently from 305f4e3 to 61aad68 Compare September 26, 2023 18:35
Signed-off-by: wadeking98 <[email protected]>
@jleach jleach self-requested a review September 26, 2023 21:01
Signed-off-by: wadeking98 <[email protected]>
@wadeking98 wadeking98 force-pushed the feat-select-proof-cred branch from a4840bd to fab2a25 Compare September 27, 2023 22:05
@bryce-mcmath bryce-mcmath added the do not merge Don't merge when label present label Sep 27, 2023
jleach
jleach previously approved these changes Sep 27, 2023
jleach
jleach previously approved these changes Oct 4, 2023
@jleach jleach removed the do not merge Don't merge when label present label Oct 19, 2023
Signed-off-by: wadeking98 <[email protected]>
@wadeking98 wadeking98 merged commit 1d8689b into openwallet-foundation:main Oct 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants