-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: select alternative credentials for proof #978
Merged
wadeking98
merged 26 commits into
openwallet-foundation:main
from
wadeking98:feat-select-proof-cred
Oct 19, 2023
Merged
feat: select alternative credentials for proof #978
wadeking98
merged 26 commits into
openwallet-foundation:main
from
wadeking98:feat-select-proof-cred
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wadeking98 <[email protected]>
…ent-react-native into feat-select-proof-cred
Signed-off-by: wadeking98 <[email protected]>
Signed-off-by: wadeking98 <[email protected]>
…ent-react-native into feat-select-proof-cred
Signed-off-by: wadeking98 <[email protected]>
Signed-off-by: wadeking98 <[email protected]>
Signed-off-by: wadeking98 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #978 +/- ##
==========================================
+ Coverage 59.82% 60.52% +0.70%
==========================================
Files 177 178 +1
Lines 5168 5323 +155
Branches 1469 1511 +42
==========================================
+ Hits 3092 3222 +130
- Misses 2051 2076 +25
Partials 25 25
|
Signed-off-by: wadeking98 <[email protected]>
Signed-off-by: wadeking98 <[email protected]>
Signed-off-by: wadeking98 <[email protected]>
Signed-off-by: wadeking98 <[email protected]>
wadeking98
force-pushed
the
feat-select-proof-cred
branch
2 times, most recently
from
September 26, 2023 18:35
305f4e3
to
61aad68
Compare
Signed-off-by: wadeking98 <[email protected]>
wadeking98
force-pushed
the
feat-select-proof-cred
branch
from
September 26, 2023 18:58
61aad68
to
8e10b2b
Compare
jleach
requested changes
Sep 26, 2023
Signed-off-by: wadeking98 <[email protected]>
…8/aries-mobile-agent-react-native into feat-select-proof-cred
Signed-off-by: wadeking98 <[email protected]>
wadeking98
force-pushed
the
feat-select-proof-cred
branch
from
September 27, 2023 22:05
a4840bd
to
fab2a25
Compare
jleach
previously approved these changes
Sep 27, 2023
Signed-off-by: wadeking98 <[email protected]>
…ent-react-native into feat-select-proof-cred
Signed-off-by: wadeking98 <[email protected]>
Signed-off-by: wadeking98 <[email protected]>
jleach
previously approved these changes
Oct 4, 2023
Signed-off-by: wadeking98 <[email protected]>
bryce-mcmath
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Added the ability to select alternate credentials for proof request when multiple creds satisfy the proof.
Related Issues
Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.