fix: disable back action by gesture after accepting terms and conditions

[fc-santos]

Summary of Changes

This PR fixes a bug where after accepting the Terms & Conditions the user is able to go back from the PINCreate Screen and then is stuck on Terms & Conditions Screen. Only killing app gets the user back on the PINCreate screen.

Screenshots, videos, or gifs

N/A

Breaking change guide

N/A

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

• All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
• If applicable, screenshots, gifs, or video are included for UI changes
• If applicable, breaking changes are described above along with how to address them
• Updated documentation as needed for changed code and new or modified features
• Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

• Read our contribution guide at least once; it will save you a few review cycles!
• Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

[cvarjao]

@fc-santos , can you elaborate a bit more on the problem. Is that on iOS, Android, both? is that on Bifold or is that on your own implementation of a wallet using bifold? It seems like getting stuck on a screen by going back seems the problem.

[fc-santos]

@cvarjao it's meant to fix this problem (occurs on both Android and iOS):

cropped.mp4

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[cvarjao]

I might be missing something, I don't think removing the ability to go back fix the problem, probably a workaround. It shouldn't get stuck as you are seeing. I think that is the problem that needs to be fixed

[bryce-mcmath]

@fc-santos adding to what Clecio said, I suspect it has to do with the checkbox no longer existing when you come back to the Terms screen. Not having it checked is probably preventing the user from continuing. Probably better to fix that underlying bug that just preventing back nav. Might be as simple as changing line 23 of Terms.tsx to:

const [checked, setChecked] = useState<boolean>(store.onboarding.didAgreeToTerms ?? false)

Edit: Or you could simply remove the checkbox. We don't use one in our injected version of the Terms screen.

[fc-santos]

@bryce-mcmath I agree that we should do what you suggested, but at the same time do we want to enable the user to go back though? The user has already accepted the conditions, why are allowing it to be accepted again?

[fc-santos]

@fc-santos adding to what Clecio said, I suspect it has to do with the checkbox no longer existing when you come back to the Terms screen. Not having it checked is probably preventing the user from continuing. Probably better to fix that underlying bug that just preventing back nav. Might be as simple as changing line 23 of Terms.tsx to:

const [checked, setChecked] = useState<boolean>(store.onboarding.didAgreeToTerms ?? false)

Edit: Or you could simply remove the checkbox. We don't use one in our injected version of the Terms screen.

@bryce-mcmath To answer your point about removing the checkbox, it's a legal requirement for us to have it.

[knguyenBC]

@bryce-mcmath I agree that we should do what you suggested, but at the same time do we want to enable the user to go back though? The user has already accepted the conditions, why are allowing it to be accepted again?

The Pan-Can design team had a discussion on this topic. We've concluded that allowing users to go back to the terms and conditions after already accepting it it is not necessary. So removing the back gesture is not a usability or UX concern.

[bryce-mcmath]

@bryce-mcmath I agree that we should do what you suggested, but at the same time do we want to enable the user to go back though? The user has already accepted the conditions, why are allowing it to be accepted again?

@fc-santos I think generally we should prefer native-style functionality where possible as it may frustrate users if they sometimes can back nav and sometimes can't. Also, increasing the amount of custom navigation mechanics might end up as tech debt. But for this specific case, I think it's fine if we make both changes - we fix the checkbox bug, and we also prevent the back nav. That's good with me 👍

[fc-santos]

@bryce-mcmath we have analyzed more the behaviour and our team agreed in the end on allowing the users to go back. I can add the check to display the checkbox so users are not stuck on the terms after moving back from the create pin screen. I’ll push the changes tomorrow.

[bryce-mcmath]

@bryce-mcmath we have analyzed more the behaviour and our team agreed in the end on allowing the users to go back. I can add the check to display the checkbox so users are not stuck on the terms after moving back from the create pin screen. I’ll push the changes tomorrow.

Sounds good! Thanks for keeping us in the loop! 🤝

[fc-santos]

@bryce-mcmath this PR can be closed and point at this new PR : #1367

[jleach]

Closing as per @fc-santos request. New one create #1367.