Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change cast from boolean to LockoutState on LOCKOUT_UPDATED action #1355

Conversation

fc-santos
Copy link
Contributor

@fc-santos fc-santos commented Dec 10, 2024

Summary of Changes

This PR fixes a bug where the LOCKOUT_UPDATED state is not being properly updated in the store. The bug occurs after the user is locked out of the app after 5 minutes. When changing the biometry settings, the pin page displays the wrong message.

Screenshots, videos, or gifs

Here is the bug:

Bug_Biometry-Settings_Toggle.mov

Breaking change guide

N/A

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • If applicable, screenshots, gifs, or video are included for UI changes
  • If applicable, breaking changes are described above along with how to address them
  • Updated documentation as needed for changed code and new or modified features
  • Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, it just needs to merge in the latest

@bryce-mcmath bryce-mcmath merged commit da17657 into openwallet-foundation:main Dec 10, 2024
8 checks passed
@fc-santos fc-santos deleted the fix/store-state-lockout-updated branch December 10, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants