Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Proof request attributes #1347

Merged
merged 22 commits into from
Dec 11, 2024

Conversation

al-rosenthal
Copy link
Contributor

@al-rosenthal al-rosenthal commented Dec 5, 2024

Summary of Changes

  • Added new prop to credential card to better describe error states
  • Updated credential card to utilize new error states
  • Fixes issue with credentials not grouping properly for a proof request
  • Restructured credential card key value pair components
  • Restructured proof request page components
  • Added more tests to check

Screenshots, videos, or gifs

Revoked Credentials in a proof request:
dummy

Predicate error in a proof:
dummy

Proof request with an extra missing attribute:
dummy

Proof request for a credential that isn't in the users wallet:
dummy

Breaking change guide

n/a

Related Issues

Replace this text with issue #'s that are relevant to this PR. If there are none, simply enter N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • If applicable, screenshots, gifs, or video are included for UI changes
  • If applicable, breaking changes are described above along with how to address them
  • Updated documentation as needed for changed code and new or modified features
  • Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

added new error array, slowly removing error instances in favor of new array

Signed-off-by: al-rosenthal <[email protected]>
Signed-off-by: al-rosenthal <[email protected]>
Signed-off-by: al-rosenthal <[email protected]>
Signed-off-by: al-rosenthal <[email protected]>
Signed-off-by: al-rosenthal <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.08197% with 6 lines in your changes missing coverage. Please review.

Project coverage is 55.64%. Comparing base (9e81308) to head (07b3a3c).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...gacy/core/App/components/misc/CredentialCard11.tsx 94.54% 3 Missing ⚠️
...legacy/core/App/components/misc/CredentialCard.tsx 75.00% 1 Missing ⚠️
packages/legacy/core/App/screens/ProofRequest.tsx 97.29% 1 Missing ⚠️
packages/legacy/core/App/utils/helpers.ts 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1347      +/-   ##
==========================================
+ Coverage   55.17%   55.64%   +0.47%     
==========================================
  Files         219      220       +1     
  Lines        7737     7853     +116     
  Branches     2192     2212      +20     
==========================================
+ Hits         4269     4370     +101     
- Misses       3446     3460      +14     
- Partials       22       23       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@al-rosenthal al-rosenthal marked this pull request as ready for review December 10, 2024 20:39
Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate the tests and screenshots 😍 Well done

@bryce-mcmath bryce-mcmath merged commit e4bb384 into openwallet-foundation:main Dec 11, 2024
8 checks passed
@al-rosenthal al-rosenthal deleted the feat/Refactor branch December 11, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants