Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rework package dependencies #1080

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

jleach
Copy link
Contributor

@jleach jleach commented Feb 1, 2024

Summary of Changes

Fixed issues with package dependencies that may cause problems.

Related Issues

n/a

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

Signed-off-by: Jason C. Leach <[email protected]>
@jleach jleach requested a review from a team as a code owner February 1, 2024 23:07
bryce-mcmath
bryce-mcmath previously approved these changes Feb 1, 2024
Signed-off-by: Jason C. Leach <[email protected]>
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eade153) 62.12% compared to head (78a09c2) 62.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1080   +/-   ##
=======================================
  Coverage   62.12%   62.12%           
=======================================
  Files         171      171           
  Lines        5470     5470           
  Branches     1572     1572           
=======================================
  Hits         3398     3398           
  Misses       2049     2049           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jleach jleach requested a review from bryce-mcmath February 1, 2024 23:19
@jleach jleach merged commit fcf5a48 into openwallet-foundation:main Feb 1, 2024
5 checks passed
@jleach jleach deleted the fix/lint-errors branch February 1, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants