-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Custom screen options dictionary: Onboarding stack only #1079
feat: Custom screen options dictionary: Onboarding stack only #1079
Conversation
Signed-off-by: OPS <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1079 +/- ##
==========================================
+ Coverage 62.48% 62.64% +0.15%
==========================================
Files 172 172
Lines 5515 5501 -14
Branches 1585 1585
==========================================
Hits 3446 3446
+ Misses 2047 2033 -14
Partials 22 22 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One issue, also some conflicts to be fixed. Otherwise looks good
Signed-off-by: OPS <[email protected]>
Signed-off-by: OPS <[email protected]>
Signed-off-by: OPS <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny change requested
Signed-off-by: Mostafa Gamal <[email protected]>
@MosCD3 Able to fix the conflicts and we'll re-review. Ty. |
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
@MosCD3 If this one is still a thing are you able to fix the conflicts. Ty. |
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
The idea is to allow host wallets to customize Bifold to a pretty much granular level without having to duplicate code. in many cases a host wallet might want to customize title bar background color or font weight without having to create the whole onboarding stack and re-inject it |
Ok, let's fix the conflicts and we'll get this merged today |
Summary of Changes
Adding more customization to the wallet by specifying a per-screen options dictionary as optional input to the wallet config with default values implemented
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.