feat: improving loginAttempt storage #1067
Conversation
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
CarolineLCa
changed the title
CarolineLCa
changed the title
CarolineLCa
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1067 +/- ##
==========================================
- Coverage 62.46% 61.57% -0.89%
==========================================
Files 172 172
Lines 5517 5528 +11
Branches 1585 1586 +1
==========================================
- Hits 3446 3404 -42
- Misses 2049 2102 +53
Partials 22 22 ☔ View full report in Codecov by Sentry. |
|
@wadeking98 @jleach @bryce-mcmath may you take a look, please? |
|
@wadeking98 can you check this one out when you have a moment? |
| @@ -95,6 +103,19 @@ export const loadWalletSalt = async (): Promise<WalletSalt | undefined> => { | |||
| return JSON.parse(result.password) as WalletSalt | |||
| } | |||
|
|
|||
| export const loadLoginAttempt = async (): Promise<LoginAttempt | undefined> => { | |||
There was a problem hiding this comment.
Can you export this method from the bifold index?
There was a problem hiding this comment.
@bryce-mcmath I didn't understand. We don't have this method in the index
There was a problem hiding this comment.
if you go into packages/legacy/core/App/index.ts and import it and export it from there then other wallets can access it, like BC Wallet. Other than that it looks good
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
| @@ -144,4 +145,5 @@ export { | |||
| components, | |||
| contexts, | |||
| Text, | |||
| loadLoginAttempt, | |||
There was a problem hiding this comment.
@wadeking98 Is this okay?
thiagoromanos
merged commit 942d9d0
into
openwallet-foundation:main
Summary of Changes
Fix issue storing
loginAttemptonkeychainRelated Issues
Resolves #1031
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.