Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removing statusBar #1062

Merged
merged 17 commits into from
Feb 13, 2024

Conversation

CarolineLCa
Copy link
Contributor

@CarolineLCa CarolineLCa commented Jan 8, 2024

Summary of Changes

Expected behavior

Change the StatusBarStyles of all screens in the application.

Current behavior

On some screens the StatusBarStyles was directly on it, making it impossible to change.

To fix

I removed the StatusBarStyles from the screens since it was already configured in App.tsx

Observation

For the modals, I added StatusBarStyles in the defaultConfiguration

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

Signed-off-by: Caroline Lucas Calheirani <[email protected]>
@CarolineLCa CarolineLCa requested a review from a team as a code owner January 8, 2024 20:25
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0177799) 62.45% compared to head (f4ce722) 62.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1062      +/-   ##
==========================================
- Coverage   62.45%   62.43%   -0.03%     
==========================================
  Files         172      172              
  Lines        5508     5505       -3     
  Branches     1583     1580       -3     
==========================================
- Hits         3440     3437       -3     
  Misses       2046     2046              
  Partials       22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Caroline Lucas Calheirani <[email protected]>
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
@jleach jleach changed the title feat:removing statusBar feat: removing statusBar Jan 10, 2024
@thiagoromanos thiagoromanos self-assigned this Jan 11, 2024
@thiagoromanos thiagoromanos removed their assignment Jan 16, 2024
@CarolineLCa
Copy link
Contributor Author

@jleach @bryce-mcmath may you take a look, please?

@bryce-mcmath
Copy link
Contributor

Since it is a style, could this setting be in the theme context as opposed to the configuration context?

@jleach
Copy link
Contributor

jleach commented Feb 9, 2024

@CarolineLCa Able to reply to @bryce-mcmath comment above?

@CarolineLCa
Copy link
Contributor Author

Since it is a style, could this setting be in the theme context as opposed to the configuration context?

I noticed that the change to the modals didn't work very well, it's being inconsistent. So I'll revert that change and leave only the removal of the StatusBarStyles from the screens.

Signed-off-by: Caroline Lucas Calheirani <[email protected]>
@jleach jleach merged commit 99f62c9 into openwallet-foundation:main Feb 13, 2024
5 checks passed
@CarolineLCa CarolineLCa deleted the feat/removing-statusBar branch June 17, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants