-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: removing statusBar #1062
feat: removing statusBar #1062
Conversation
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1062 +/- ##
==========================================
- Coverage 62.45% 62.43% -0.03%
==========================================
Files 172 172
Lines 5508 5505 -3
Branches 1583 1580 -3
==========================================
- Hits 3440 3437 -3
Misses 2046 2046
Partials 22 22 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
@jleach @bryce-mcmath may you take a look, please? |
Since it is a style, could this setting be in the theme context as opposed to the configuration context? |
@CarolineLCa Able to reply to @bryce-mcmath comment above? |
I noticed that the change to the modals didn't work very well, it's being inconsistent. So I'll revert that change and leave only the removal of the |
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
Summary of Changes
Expected behavior
Change the
StatusBarStyles
of all screens in the application.Current behavior
On some screens the
StatusBarStyles
was directly on it, making it impossible to change.To fix
I removed the
StatusBarStyles
from the screens since it was already configured inApp.tsx
Observation
For the modals, I added
StatusBarStyles
in thedefaultConfiguration
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.