-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: putting theme in fontWeight bold and normal #1061
feat: putting theme in fontWeight bold and normal #1061
Conversation
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
=======================================
Coverage 62.11% 62.12%
=======================================
Files 171 171
Lines 5469 5470 +1
Branches 1572 1572
=======================================
+ Hits 3397 3398 +1
Misses 2049 2049
Partials 23 23 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the comment about the PINEnter file
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary of Changes
Expected behavior
Use any
fontFamily
you want in the application.Actual behavior
On some screens the
fontWeight
was directly on it, fonts that use numericfontWeight
were not working.To fix
I added the
fontWeight
directly from thetheme
Observation
I added
marginTop: 30
to the PINEnter screen image, as it was too high up, taking the risk of being cut off on some devices when the keyboard is shown.Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.