Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: putting theme in fontWeight bold and normal #1061

Conversation

CarolineLCa
Copy link
Contributor

Summary of Changes

Expected behavior

Use any fontFamily you want in the application.

Actual behavior

On some screens the fontWeight was directly on it, fonts that use numeric fontWeight were not working.

To fix

I added the fontWeight directly from the theme

Observation

I added marginTop: 30 to the PINEnter screen image, as it was too high up, taking the risk of being cut off on some devices when the keyboard is shown.

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

Signed-off-by: Caroline Lucas Calheirani <[email protected]>
@CarolineLCa CarolineLCa requested a review from a team as a code owner January 8, 2024 19:25
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (966fedf) 62.11% compared to head (e56f810) 62.12%.

Files Patch % Lines
packages/legacy/core/App/navigators/TabStack.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1061   +/-   ##
=======================================
  Coverage   62.11%   62.12%           
=======================================
  Files         171      171           
  Lines        5469     5470    +1     
  Branches     1572     1572           
=======================================
+ Hits         3397     3398    +1     
  Misses       2049     2049           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jleach jleach changed the title feat:Putting theme in fontWeight bold and normal feat: putting theme in fontWeight bold and normal Jan 10, 2024
@thiagoromanos thiagoromanos self-assigned this Jan 11, 2024
@thiagoromanos thiagoromanos removed their assignment Jan 16, 2024
@thiagoromanos thiagoromanos self-assigned this Jan 24, 2024
Copy link
Contributor

@thiagoromanos thiagoromanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the comment about the PINEnter file

packages/legacy/core/App/screens/PINEnter.tsx Outdated Show resolved Hide resolved
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
Copy link
Contributor

@thiagoromanos thiagoromanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thiagoromanos thiagoromanos merged commit 4bbf7c6 into openwallet-foundation:main Jan 29, 2024
7 checks passed
@CarolineLCa CarolineLCa deleted the feat/adjusting-fontWeight-bold branch June 6, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants