fix: in app guides orientation on ipad #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bryce McMath <[email protected]>
Signed-off-by: Bryce McMath <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1055 +/- ##
==========================================
+ Coverage 61.50% 61.52% +0.02%
==========================================
Files 170 170
Lines 5453 5456 +3
Branches 1570 1570
==========================================
+ Hits 3354 3357 +3
Misses 2075 2075
Partials 24 24 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Bryce McMath <[email protected]>
jleach
requested changes
Jan 3, 2024
| @@ -52,7 +52,7 @@ export const TourOverlay = (props: TourOverlayProps) => { | |||
| const gapBetweenSpotAndTooltip = 50 | |||
| // if origin spot (ie. no spotlight) | |||
| if (spot.x === 0 && spot.y === 0) { | |||
| const top = windowHeight / 5 | |||
| const top = windowHeight / 6 | |||
There was a problem hiding this comment.
Magic number? Able to define as a const like you do for 50 above?
There was a problem hiding this comment.
I've made the variable name more descriptive and added a comment above it. I only use it in one place and it is just some relative spacing of one sixth the screen height so that the tooltip doesn't start at the very top of the screen. I'm not sure what I was name the six if I made it a const. Hopefully the descriptive var name and comment is enough
Signed-off-by: Bryce McMath <[email protected]>
jleach
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Potential fix for the orientation issues the in app guides have on ipads
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.