Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iOS app permissions #1053

Merged

Conversation

MosCD3
Copy link
Contributor

@MosCD3 MosCD3 commented Dec 31, 2023

Summary of Changes

iOS 14+ uses local network permissions at app start which triggers permissions package to start, incorrectly configured Podfile and outdated package version cause an exception trigger at iOS app startup
Updated react-native-permissions package and added configuration in Podfile
Also tested Android to make sure updating package doesn't affect the flow

IMG_0272

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

@MosCD3 MosCD3 requested a review from a team as a code owner December 31, 2023 02:19
Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (93547bc) 62.12% compared to head (9054619) 62.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1053   +/-   ##
=======================================
  Coverage   62.12%   62.12%           
=======================================
  Files         171      171           
  Lines        5470     5470           
  Branches     1572     1572           
=======================================
  Hits         3398     3398           
  Misses       2049     2049           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jleach jleach changed the title Fix iOS app permissions fix: iOS app permissions Jan 2, 2024
@cvarjao
Copy link
Contributor

cvarjao commented Jan 12, 2024

@MosCD3 , can't we use the reactNativePermissionsIOS.json configuration file instead of changing the cocoa pod configuration file?

@jleach
Copy link
Contributor

jleach commented Jan 16, 2024

This may be unique to your development environment. I don't see this. I do some times see, when the app starts, it ask for permission to use the network. I just answer yes and it seems to work fine. I think this is proper behaviour for iOS though.

@MosCD3
Copy link
Contributor Author

MosCD3 commented Jan 16, 2024

keep it a bit until I retest if not a solution I will close it

@jleach
Copy link
Contributor

jleach commented Jan 31, 2024

@MosCD3 I was running Bifold the other day and ran into this problem. I think it may be needed here. Are you able to fix the conflicts so it can be merged?

@MosCD3
Copy link
Contributor Author

MosCD3 commented Jan 31, 2024

Yes sure, will do that

@jleach jleach merged commit 10ea69a into openwallet-foundation:main Feb 1, 2024
7 checks passed
@MosCD3 MosCD3 deleted the bugfix/moscd3/fix-ios-permissions branch July 24, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants