-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: iOS app permissions #1053
fix: iOS app permissions #1053
Conversation
Signed-off-by: OPS <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1053 +/- ##
=======================================
Coverage 62.12% 62.12%
=======================================
Files 171 171
Lines 5470 5470
Branches 1572 1572
=======================================
Hits 3398 3398
Misses 2049 2049
Partials 23 23 ☔ View full report in Codecov by Sentry. |
@MosCD3 , can't we use the reactNativePermissionsIOS.json configuration file instead of changing the cocoa pod configuration file? |
This may be unique to your development environment. I don't see this. I do some times see, when the app starts, it ask for permission to use the network. I just answer yes and it seems to work fine. I think this is proper behaviour for iOS though. |
keep it a bit until I retest if not a solution I will close it |
@MosCD3 I was running Bifold the other day and ran into this problem. I think it may be needed here. Are you able to fix the conflicts so it can be merged? |
Yes sure, will do that |
Signed-off-by: OPS <[email protected]>
Summary of Changes
iOS 14+ uses local network permissions at app start which triggers permissions package to start, incorrectly configured Podfile and outdated package version cause an exception trigger at iOS app startup
Updated
react-native-permissions
package and added configuration in PodfileAlso tested Android to make sure updating package doesn't affect the flow
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this);